media: s5p-mfc: Fix display delay control creation

mszyprow · mchehab · commit 61c6f04a988e · 2021-06-28T15:17:42.000+02:00
v4l2_ctrl_new_std() fails if the caller provides no 'step' parameter for integer control, so define it to fix following error: s5p_mfc_dec_ctrls_setup:1166: Adding control (1) failed Fixes: c3042bf ("media: s5p-mfc: Use display delay and display enable std controls") Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -172,6 +172,7 @@ static struct mfc_control controls[] = {
 		.type = V4L2_CTRL_TYPE_INTEGER,
 		.minimum = 0,
 		.maximum = 16383,
+		.step = 1,
 		.default_value = 0,
 	},
 	{

Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,7 @@ static struct mfc_control controls[] = {`
`172`	`172`	`.type = V4L2_CTRL_TYPE_INTEGER,`
`173`	`173`	`.minimum = 0,`
`174`	`174`	`.maximum = 16383,`
	`175`	`+ .step = 1,`
`175`	`176`	`.default_value = 0,`
`176`	`177`	`},`
`177`	`178`	`{`