Skip to content

Commit 62d8779

Browse files
committed
Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
Pull ext4 fixes from Ted Ts'o: "Fix two regressions in ext4, one report by syzkaller[1], and reported by multiple users (and tracked by regzbot[2])" [1] https://syzkaller.appspot.com/bug?extid=4acc7d910e617b360859 [2] https://linux-regtracking.leemhuis.info/regzbot/regression/ZIauBR7YiV3rVAHL@glitch/ * tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4: ext4: drop the call to ext4_error() from ext4_get_group_info() Revert "ext4: remove unnecessary check in ext4_bg_num_gdb_nometa"
2 parents 7a043fe + f451fd9 commit 62d8779

1 file changed

Lines changed: 13 additions & 12 deletions

File tree

fs/ext4/balloc.c

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -324,17 +324,15 @@ static ext4_fsblk_t ext4_valid_block_bitmap_padding(struct super_block *sb,
324324
struct ext4_group_info *ext4_get_group_info(struct super_block *sb,
325325
ext4_group_t group)
326326
{
327-
struct ext4_group_info **grp_info;
328-
long indexv, indexh;
329-
330-
if (unlikely(group >= EXT4_SB(sb)->s_groups_count)) {
331-
ext4_error(sb, "invalid group %u", group);
332-
return NULL;
333-
}
334-
indexv = group >> (EXT4_DESC_PER_BLOCK_BITS(sb));
335-
indexh = group & ((EXT4_DESC_PER_BLOCK(sb)) - 1);
336-
grp_info = sbi_array_rcu_deref(EXT4_SB(sb), s_group_info, indexv);
337-
return grp_info[indexh];
327+
struct ext4_group_info **grp_info;
328+
long indexv, indexh;
329+
330+
if (unlikely(group >= EXT4_SB(sb)->s_groups_count))
331+
return NULL;
332+
indexv = group >> (EXT4_DESC_PER_BLOCK_BITS(sb));
333+
indexh = group & ((EXT4_DESC_PER_BLOCK(sb)) - 1);
334+
grp_info = sbi_array_rcu_deref(EXT4_SB(sb), s_group_info, indexv);
335+
return grp_info[indexh];
338336
}
339337

340338
/*
@@ -886,7 +884,10 @@ static unsigned long ext4_bg_num_gdb_nometa(struct super_block *sb,
886884
if (!ext4_bg_has_super(sb, group))
887885
return 0;
888886

889-
return EXT4_SB(sb)->s_gdb_count;
887+
if (ext4_has_feature_meta_bg(sb))
888+
return le32_to_cpu(EXT4_SB(sb)->s_es->s_first_meta_bg);
889+
else
890+
return EXT4_SB(sb)->s_gdb_count;
890891
}
891892

892893
/**

0 commit comments

Comments
 (0)