pwm: max7360: Populate missing .sizeof_wfhw in max7360_pwm_ops

richard-bootlin · Uwe Kleine-König · commit 63faf32666e0 · 2026-01-19T18:31:05.000+01:00
The sizeof_wfhw field wasn't populated in max7360_pwm_ops so it was set to 0 by default. While this is ok for now because: sizeof(struct max7360_pwm_waveform) < PWM_WFHWSIZE in the future, if struct max7360_pwm_waveform grows, it could lead to stack corruption. Fixes: d93a75d ("pwm: max7360: Add MAX7360 PWM support") Signed-off-by: Richard Genoud <richard.genoud@bootlin.com> Link: https://patch.msgid.link/20260113163907.368919-1-richard.genoud@bootlin.com Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
diff --git a/drivers/pwm/pwm-max7360.c b/drivers/pwm/pwm-max7360.c
@@ -153,6 +153,7 @@ static int max7360_pwm_read_waveform(struct pwm_chip *chip,
 }
 
 static const struct pwm_ops max7360_pwm_ops = {
+	.sizeof_wfhw = sizeof(struct max7360_pwm_waveform),
 	.request = max7360_pwm_request,
 	.round_waveform_tohw = max7360_pwm_round_waveform_tohw,
 	.round_waveform_fromhw = max7360_pwm_round_waveform_fromhw,

Original file line number	Diff line number	Diff line change
`@@ -153,6 +153,7 @@ static int max7360_pwm_read_waveform(struct pwm_chip *chip,`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`static const struct pwm_ops max7360_pwm_ops = {`
	`156`	`+ .sizeof_wfhw = sizeof(struct max7360_pwm_waveform),`
`156`	`157`	`.request = max7360_pwm_request,`
`157`	`158`	`.round_waveform_tohw = max7360_pwm_round_waveform_tohw,`
`158`	`159`	`.round_waveform_fromhw = max7360_pwm_round_waveform_fromhw,`