Skip to content

Commit 643e12d

Browse files
Jean-Philippe Bruckerctmarinas
authored andcommitted
arm64: psci: Ignore DENIED CPUs
When a CPU is marked as disabled, but online capable in the MADT, PSCI applies some firmware policy to control when it can be brought online. PSCI returns DENIED to a CPU_ON request if this is not currently permitted. The OS can learn the current policy from the _STA enabled bit. Handle the PSCI DENIED return code gracefully instead of printing an error. Note the alternatives to the PSCI cpu_boot() callback do not return -EPERM so the change in smp.c has no affect. See https://developer.arm.com/documentation/den0022/f/?lang=en page 58. Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> [ morse: Rewrote commit message ] Signed-off-by: James Morse <james.morse@arm.com> Tested-by: Miguel Luis <miguel.luis@oracle.com> Tested-by: Vishnu Pajjuri <vishnu@os.amperecomputing.com> Tested-by: Jianyong Wu <jianyong.wu@arm.com> Reviewed-by: Gavin Shan <gshan@redhat.com> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Link: https://lore.kernel.org/r/20240529133446.28446-16-Jonathan.Cameron@huawei.com Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
1 parent d633da5 commit 643e12d

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

arch/arm64/kernel/psci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ static int cpu_psci_cpu_boot(unsigned int cpu)
4040
{
4141
phys_addr_t pa_secondary_entry = __pa_symbol(secondary_entry);
4242
int err = psci_ops.cpu_on(cpu_logical_map(cpu), pa_secondary_entry);
43-
if (err)
43+
if (err && err != -EPERM)
4444
pr_err("failed to boot CPU%d (%d)\n", cpu, err);
4545

4646
return err;

arch/arm64/kernel/smp.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,8 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
132132
/* Now bring the CPU into our world */
133133
ret = boot_secondary(cpu, idle);
134134
if (ret) {
135-
pr_err("CPU%u: failed to boot: %d\n", cpu, ret);
135+
if (ret != -EPERM)
136+
pr_err("CPU%u: failed to boot: %d\n", cpu, ret);
136137
return ret;
137138
}
138139

0 commit comments

Comments
 (0)