drm/xe: Drop VM dma-resv lock on xe_sync_in_fence_get failure in exec IOCTL

mbrost05 · Lucas De Marchi · commit 64a2b6ed4bfd · 2024-11-05T15:40:12.000-08:00
Upon failure all locks need to be dropped before returning to the user. Fixes: 58480c1 ("drm/xe: Skip VMAs pin when requesting signal to the last XE_EXEC") Cc: <stable@vger.kernel.org> Signed-off-by: Matthew Brost <matthew.brost@intel.com> Reviewed-by: Tejas Upadhyay <tejas.upadhyay@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20241105043524.4062774-3-matthew.brost@intel.com (cherry picked from commit 7d1a425) Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
diff --git a/drivers/gpu/drm/xe/xe_exec.c b/drivers/gpu/drm/xe/xe_exec.c
@@ -224,6 +224,7 @@ int xe_exec_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
 			fence = xe_sync_in_fence_get(syncs, num_syncs, q, vm);
 			if (IS_ERR(fence)) {
 				err = PTR_ERR(fence);
+				xe_vm_unlock(vm);
 				goto err_unlock_list;
 			}
 			for (i = 0; i < num_syncs; i++)

Original file line number	Diff line number	Diff line change
`@@ -224,6 +224,7 @@ int xe_exec_ioctl(struct drm_device dev, void data, struct drm_file *file)`
`224`	`224`	`fence = xe_sync_in_fence_get(syncs, num_syncs, q, vm);`
`225`	`225`	`if (IS_ERR(fence)) {`
`226`	`226`	`err = PTR_ERR(fence);`
	`227`	`+ xe_vm_unlock(vm);`
`227`	`228`	`goto err_unlock_list;`
`228`	`229`	`}`
`229`	`230`	`for (i = 0; i < num_syncs; i++)`