mfd: wcd934x: Drop kfree for memory allocated with devm_kzalloc

Wei Yongjun · Lee Jones · commit 652b7b6740eb · 2020-05-26T10:51:21.000+01:00
It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Fixes: 6ac7e4d ("mfd: wcd934x: Add support to wcd9340/wcd9341 codec") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
diff --git a/drivers/mfd/wcd934x.c b/drivers/mfd/wcd934x.c
@@ -280,7 +280,6 @@ static void wcd934x_slim_remove(struct slim_device *sdev)
 
 	regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies);
 	mfd_remove_devices(&sdev->dev);
-	kfree(ddata);
 }
 
 static const struct slim_device_id wcd934x_slim_id[] = {

Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,6 @@ static void wcd934x_slim_remove(struct slim_device *sdev)`
`280`	`280`
`281`	`281`	`regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies);`
`282`	`282`	`mfd_remove_devices(&sdev->dev);`
`283`		`- kfree(ddata);`
`284`	`283`	`}`
`285`	`284`
`286`	`285`	`static const struct slim_device_id wcd934x_slim_id[] = {`