scsi: isci: Fix an error code problem in isci_io_request_build()

Su Hui · martinkpetersen · commit 658365c6b085 · 2024-01-17T14:43:41.000-05:00
Clang static complains that Value stored to 'status' is never read. Return 'status' rather than 'SCI_SUCCESS'. Fixes: f1f52e7 ("isci: uplevel request infrastructure") Signed-off-by: Su Hui <suhui@nfschina.com> Link: https://lore.kernel.org/r/20240112041926.3924315-1-suhui@nfschina.com Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
@@ -3387,7 +3387,7 @@ static enum sci_status isci_io_request_build(struct isci_host *ihost,
 		return SCI_FAILURE;
 	}
 
-	return SCI_SUCCESS;
+	return status;
 }
 
 static struct isci_request *isci_request_from_tag(struct isci_host *ihost, u16 tag)

Original file line number	Diff line number	Diff line change
`@@ -3387,7 +3387,7 @@ static enum sci_status isci_io_request_build(struct isci_host *ihost,`
`3387`	`3387`	`return SCI_FAILURE;`
`3388`	`3388`	`}`
`3389`	`3389`
`3390`		`- return SCI_SUCCESS;`
	`3390`	`+ return status;`
`3391`	`3391`	`}`
`3392`	`3392`
`3393`	`3393`	`static struct isci_request isci_request_from_tag(struct isci_host ihost, u16 tag)`