Skip to content

Commit 66477c7

Browse files
Peter Zijlstraingomolnar
authored andcommitted
perf/core: Fix perf_mmap() failure path
When f_ops->mmap() returns failure, m_ops->close() is *not* called. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Acked-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> Link: https://lore.kernel.org/r/20241104135519.248358497@infradead.org
1 parent 4eabf53 commit 66477c7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

kernel/events/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6903,7 +6903,7 @@ static int perf_mmap(struct file *file, struct vm_area_struct *vma)
69036903
if (!ret)
69046904
ret = map_range(rb, vma);
69056905

6906-
if (event->pmu->event_mapped)
6906+
if (!ret && event->pmu->event_mapped)
69076907
event->pmu->event_mapped(event, vma->vm_mm);
69086908

69096909
return ret;

0 commit comments

Comments
 (0)