Skip to content

Commit 664d8db

Browse files
author
Uwe Kleine-König
committed
pwm: bcm2835: Introduce a local variable for &pdev->dev
&pdev->dev is used several times in bcm2835_pwm_probe(). Introduce a local variable to simplify all usages. Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://lore.kernel.org/r/3f302472e30e21c7ef5624a1d0a2890d9fdf3c7f.1710078146.git.u.kleine-koenig@pengutronix.de Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
1 parent 8002fbe commit 664d8db

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

drivers/pwm/pwm-bcm2835.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,12 @@ static void devm_clk_rate_exclusive_put(void *data)
133133

134134
static int bcm2835_pwm_probe(struct platform_device *pdev)
135135
{
136+
struct device *dev = &pdev->dev;
136137
struct pwm_chip *chip;
137138
struct bcm2835_pwm *pc;
138139
int ret;
139140

140-
chip = devm_pwmchip_alloc(&pdev->dev, 2, sizeof(*pc));
141+
chip = devm_pwmchip_alloc(dev, 2, sizeof(*pc));
141142
if (IS_ERR(chip))
142143
return PTR_ERR(chip);
143144
pc = to_bcm2835_pwm(chip);
@@ -146,35 +147,34 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
146147
if (IS_ERR(pc->base))
147148
return PTR_ERR(pc->base);
148149

149-
pc->clk = devm_clk_get_enabled(&pdev->dev, NULL);
150+
pc->clk = devm_clk_get_enabled(dev, NULL);
150151
if (IS_ERR(pc->clk))
151-
return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
152+
return dev_err_probe(dev, PTR_ERR(pc->clk),
152153
"clock not found\n");
153154

154155
ret = clk_rate_exclusive_get(pc->clk);
155156
if (ret)
156-
return dev_err_probe(&pdev->dev, ret,
157+
return dev_err_probe(dev, ret,
157158
"fail to get exclusive rate\n");
158159

159-
ret = devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put,
160+
ret = devm_add_action_or_reset(dev, devm_clk_rate_exclusive_put,
160161
pc->clk);
161162
if (ret)
162163
return ret;
163164

164165
pc->rate = clk_get_rate(pc->clk);
165166
if (!pc->rate)
166-
return dev_err_probe(&pdev->dev, -EINVAL,
167+
return dev_err_probe(dev, -EINVAL,
167168
"failed to get clock rate\n");
168169

169170
chip->ops = &bcm2835_pwm_ops;
170171
chip->atomic = true;
171172

172173
platform_set_drvdata(pdev, pc);
173174

174-
ret = devm_pwmchip_add(&pdev->dev, chip);
175+
ret = devm_pwmchip_add(dev, chip);
175176
if (ret < 0)
176-
return dev_err_probe(&pdev->dev, ret,
177-
"failed to add pwmchip\n");
177+
return dev_err_probe(dev, ret, "failed to add pwmchip\n");
178178

179179
return 0;
180180
}

0 commit comments

Comments
 (0)