Skip to content

Commit 666d3b6

Browse files
ColinIanKingtiwai
authored andcommitted
ALSA: ice1712: remove redundant assignment to new
The variable new is initialized with a value but it is never read. It is being re-assigned a new value in every case path in the following switch statement. The assignment is redundant and can be removed. Cleans up clang scan build warning: sound/pci/ice1712/quartet.c:569:8: warning: Although the value stored to 'new' is used in the enclosing expression, the value is never actually read from 'new' [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20220805120439.2341600-1-colin.i.king@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent f882c4b commit 666d3b6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/pci/ice1712/quartet.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ static int qtet_ain12_sw_put(struct snd_kcontrol *kcontrol,
566566
{
567567
struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
568568
unsigned int old, new, tmp, masked_old;
569-
old = new = get_scr(ice);
569+
old = get_scr(ice);
570570
masked_old = old & (SCR_AIN12_SEL1 | SCR_AIN12_SEL0);
571571
tmp = ucontrol->value.integer.value[0];
572572
if (tmp == 2)

0 commit comments

Comments
 (0)