Skip to content

Commit 66e4442

Browse files
krzkJassi Brar
authored andcommitted
mailbox: zynqmp-ipi: Simplify with scoped for each OF child loop
Use scoped for-each loop when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
1 parent 7271bca commit 66e4442

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/mailbox/zynqmp-ipi-mailbox.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -904,7 +904,7 @@ static void zynqmp_ipi_free_mboxes(struct zynqmp_ipi_pdata *pdata)
904904
static int zynqmp_ipi_probe(struct platform_device *pdev)
905905
{
906906
struct device *dev = &pdev->dev;
907-
struct device_node *nc, *np = pdev->dev.of_node;
907+
struct device_node *np = pdev->dev.of_node;
908908
struct zynqmp_ipi_pdata *pdata;
909909
struct of_phandle_args out_irq;
910910
struct zynqmp_ipi_mbox *mbox;
@@ -940,13 +940,12 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
940940
pdata->num_mboxes = num_mboxes;
941941

942942
mbox = pdata->ipi_mboxes;
943-
for_each_available_child_of_node(np, nc) {
943+
for_each_available_child_of_node_scoped(np, nc) {
944944
mbox->pdata = pdata;
945945
mbox->setup_ipi_fn = ipi_fn;
946946

947947
ret = zynqmp_ipi_mbox_probe(mbox, nc);
948948
if (ret) {
949-
of_node_put(nc);
950949
dev_err(dev, "failed to probe subdev.\n");
951950
ret = -EINVAL;
952951
goto free_mbox_dev;

0 commit comments

Comments
 (0)