HID: fix memdup.cocci warnings

intel-lab-lkp · Jiri Kosina · commit 66ff89946e6a · 2021-03-30T09:44:31.000+02:00
drivers/hid/hid-thrustmaster.c:300:27-34: WARNING opportunity for kmemdup Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: c49c336 ("HID: support for initialization of some Thrustmaster wheels") CC: Dario Pagani <dario.pagani.146@gmail.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
@@ -297,12 +297,13 @@ static int thrustmaster_probe(struct hid_device *hdev, const struct hid_device_i
 		goto error2;
 	}
 
-	tm_wheel->model_request = kzalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL);
+	tm_wheel->model_request = kmemdup(&model_request,
+					  sizeof(struct usb_ctrlrequest),
+					  GFP_KERNEL);
 	if (!tm_wheel->model_request) {
 		ret = -ENOMEM;
 		goto error3;
 	}
-	memcpy(tm_wheel->model_request, &model_request, sizeof(struct usb_ctrlrequest));
 
 	tm_wheel->response = kzalloc(sizeof(struct tm_wheel_response), GFP_KERNEL);
 	if (!tm_wheel->response) {

Original file line number	Diff line number	Diff line change
`@@ -297,12 +297,13 @@ static int thrustmaster_probe(struct hid_device *hdev, const struct hid_device_i`
`297`	`297`	`goto error2;`
`298`	`298`	`}`
`299`	`299`
`300`		`- tm_wheel->model_request = kzalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL);`
	`300`	`+ tm_wheel->model_request = kmemdup(&model_request,`
	`301`	`+ sizeof(struct usb_ctrlrequest),`
	`302`	`+ GFP_KERNEL);`
`301`	`303`	`if (!tm_wheel->model_request) {`
`302`	`304`	`ret = -ENOMEM;`
`303`	`305`	`goto error3;`
`304`	`306`	`}`
`305`		`- memcpy(tm_wheel->model_request, &model_request, sizeof(struct usb_ctrlrequest));`
`306`	`307`
`307`	`308`	`tm_wheel->response = kzalloc(sizeof(struct tm_wheel_response), GFP_KERNEL);`
`308`	`309`	`if (!tm_wheel->response) {`