Skip to content

Commit 671bb35

Browse files
SandyWinterdavem330
authored andcommitted
s390/lcs: fix variable dereferenced before check
smatch complains about drivers/s390/net/lcs.c:1741 lcs_get_control() warn: variable dereferenced before check 'card->dev' (see line 1739) Fixes: 27eb5ac ("[PATCH] s390: lcs driver bug fixes and improvements [1/2]") Signed-off-by: Alexandra Winter <wintera@linux.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 0c0b205 commit 671bb35

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

drivers/s390/net/lcs.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1736,10 +1736,11 @@ lcs_get_control(struct lcs_card *card, struct lcs_cmd *cmd)
17361736
lcs_schedule_recovery(card);
17371737
break;
17381738
case LCS_CMD_STOPLAN:
1739-
pr_warn("Stoplan for %s initiated by LGW\n",
1740-
card->dev->name);
1741-
if (card->dev)
1739+
if (card->dev) {
1740+
pr_warn("Stoplan for %s initiated by LGW\n",
1741+
card->dev->name);
17421742
netif_carrier_off(card->dev);
1743+
}
17431744
break;
17441745
default:
17451746
LCS_DBF_TEXT(5, trace, "noLGWcmd");

0 commit comments

Comments
 (0)