Skip to content

Commit 6722e46

Browse files
KanjiMonsterarndb
authored andcommitted
bus: ixp4xx: fix IXP4XX_EXP_T1_MASK
The IXP4XX_EXP_T1_MASK was shifted one bit to the right, overlapping IXP4XX_EXP_T2_MASK and leaving bit 29 unused. The offset being wrong is also confirmed at least by the datasheet of IXP45X/46X [1]. Fix this by aligning it to IXP4XX_EXP_T1_SHIFT. [1] https://www.intel.com/content/dam/www/public/us/en/documents/manuals/ixp45x-ixp46x-developers-manual.pdf Cc: stable@vger.kernel.org Fixes: 1c953bd ("bus: ixp4xx: Add a driver for IXP4xx expansion bus") Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Link: https://lore.kernel.org/r/20230624112958.27727-1-jonas.gorski@gmail.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20230624122139.3229642-1-linus.walleij@linaro.org Signed-off-by: Arnd Bergmann <arnd@arndb.de>
1 parent 7fb7590 commit 6722e46

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/bus/intel-ixp4xx-eb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
#define IXP4XX_EXP_TIMING_STRIDE 0x04
3434
#define IXP4XX_EXP_CS_EN BIT(31)
3535
#define IXP456_EXP_PAR_EN BIT(30) /* Only on IXP45x and IXP46x */
36-
#define IXP4XX_EXP_T1_MASK GENMASK(28, 27)
36+
#define IXP4XX_EXP_T1_MASK GENMASK(29, 28)
3737
#define IXP4XX_EXP_T1_SHIFT 28
3838
#define IXP4XX_EXP_T2_MASK GENMASK(27, 26)
3939
#define IXP4XX_EXP_T2_SHIFT 26

0 commit comments

Comments
 (0)