Skip to content

Commit 6731f85

Browse files
Christoph Hellwigcmaiolino
authored andcommitted
xfs: remove the xlog_in_core_t typedef
Switch the few remaining users to use the underlying struct directly. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> Signed-off-by: Carlos Maiolino <cem@kernel.org>
1 parent bc2dd9f commit 6731f85

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

fs/xfs/xfs_log.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1368,8 +1368,8 @@ xlog_alloc_log(
13681368
int num_bblks)
13691369
{
13701370
struct xlog *log;
1371-
xlog_in_core_t **iclogp;
1372-
xlog_in_core_t *iclog, *prev_iclog=NULL;
1371+
struct xlog_in_core **iclogp;
1372+
struct xlog_in_core *iclog, *prev_iclog = NULL;
13731373
int i;
13741374
int error = -ENOMEM;
13751375
uint log2_size = 0;
@@ -1813,10 +1813,10 @@ xlog_sync(
18131813
*/
18141814
STATIC void
18151815
xlog_dealloc_log(
1816-
struct xlog *log)
1816+
struct xlog *log)
18171817
{
1818-
xlog_in_core_t *iclog, *next_iclog;
1819-
int i;
1818+
struct xlog_in_core *iclog, *next_iclog;
1819+
int i;
18201820

18211821
/*
18221822
* Destroy the CIL after waiting for iclog IO completion because an
@@ -3293,7 +3293,7 @@ xlog_verify_iclog(
32933293
int count)
32943294
{
32953295
struct xlog_rec_header *rhead = iclog->ic_header;
3296-
xlog_in_core_t *icptr;
3296+
struct xlog_in_core *icptr;
32973297
void *base_ptr, *ptr;
32983298
ptrdiff_t field_offset;
32993299
uint8_t clientid;
@@ -3481,11 +3481,10 @@ xlog_force_shutdown(
34813481

34823482
STATIC int
34833483
xlog_iclogs_empty(
3484-
struct xlog *log)
3484+
struct xlog *log)
34853485
{
3486-
xlog_in_core_t *iclog;
3486+
struct xlog_in_core *iclog = log->l_iclog;
34873487

3488-
iclog = log->l_iclog;
34893488
do {
34903489
/* endianness does not matter here, zero is zero in
34913490
* any language.
@@ -3494,6 +3493,7 @@ xlog_iclogs_empty(
34943493
return 0;
34953494
iclog = iclog->ic_next;
34963495
} while (iclog != log->l_iclog);
3496+
34973497
return 1;
34983498
}
34993499

fs/xfs/xfs_log_priv.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ struct xlog_ticket {
181181
* We'll put all the read-only and l_icloglock fields in the first cacheline,
182182
* and move everything else out to subsequent cachelines.
183183
*/
184-
typedef struct xlog_in_core {
184+
struct xlog_in_core {
185185
wait_queue_head_t ic_force_wait;
186186
wait_queue_head_t ic_write_wait;
187187
struct xlog_in_core *ic_next;
@@ -204,7 +204,7 @@ typedef struct xlog_in_core {
204204
struct work_struct ic_end_io_work;
205205
struct bio ic_bio;
206206
struct bio_vec ic_bvec[];
207-
} xlog_in_core_t;
207+
};
208208

209209
/*
210210
* The CIL context is used to aggregate per-transaction details as well be
@@ -418,7 +418,7 @@ struct xlog {
418418
/* waiting for iclog flush */
419419
int l_covered_state;/* state of "covering disk
420420
* log entries" */
421-
xlog_in_core_t *l_iclog; /* head log queue */
421+
struct xlog_in_core *l_iclog; /* head log queue */
422422
spinlock_t l_icloglock; /* grab to change iclog state */
423423
int l_curr_cycle; /* Cycle number of log writes */
424424
int l_prev_cycle; /* Cycle number before last

0 commit comments

Comments
 (0)