Skip to content

Commit 6738053

Browse files
krzkbroonie
authored andcommitted
ASoC: codecs: wcd9335: Simplify with dev_err_probe
Code can be a bit simpler with dev_err_probe(). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20230417141453.919158-1-krzysztof.kozlowski@linaro.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent c341b56 commit 6738053

1 file changed

Lines changed: 11 additions & 16 deletions

File tree

sound/soc/codecs/wcd9335.c

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5138,20 +5138,17 @@ static int wcd9335_irq_init(struct wcd9335_codec *wcd)
51385138
* INTR2 is a subset of first interrupt sources MAD, VBAT, and SVA
51395139
*/
51405140
wcd->intr1 = of_irq_get_byname(wcd->dev->of_node, "intr1");
5141-
if (wcd->intr1 < 0) {
5142-
if (wcd->intr1 != -EPROBE_DEFER)
5143-
dev_err(wcd->dev, "Unable to configure IRQ\n");
5144-
5145-
return wcd->intr1;
5146-
}
5141+
if (wcd->intr1 < 0)
5142+
return dev_err_probe(wcd->dev, wcd->intr1,
5143+
"Unable to configure IRQ\n");
51475144

51485145
ret = devm_regmap_add_irq_chip(wcd->dev, wcd->regmap, wcd->intr1,
51495146
IRQF_TRIGGER_HIGH, 0,
51505147
&wcd9335_regmap_irq1_chip, &wcd->irq_data);
51515148
if (ret)
5152-
dev_err(wcd->dev, "Failed to register IRQ chip: %d\n", ret);
5149+
return dev_err_probe(wcd->dev, ret, "Failed to register IRQ chip\n");
51535150

5154-
return ret;
5151+
return 0;
51555152
}
51565153

51575154
static int wcd9335_slim_probe(struct slim_device *slim)
@@ -5207,17 +5204,15 @@ static int wcd9335_slim_status(struct slim_device *sdev,
52075204
slim_get_logical_addr(wcd->slim_ifc_dev);
52085205

52095206
wcd->regmap = regmap_init_slimbus(sdev, &wcd9335_regmap_config);
5210-
if (IS_ERR(wcd->regmap)) {
5211-
dev_err(dev, "Failed to allocate slim register map\n");
5212-
return PTR_ERR(wcd->regmap);
5213-
}
5207+
if (IS_ERR(wcd->regmap))
5208+
return dev_err_probe(dev, PTR_ERR(wcd->regmap),
5209+
"Failed to allocate slim register map\n");
52145210

52155211
wcd->if_regmap = regmap_init_slimbus(wcd->slim_ifc_dev,
52165212
&wcd9335_ifc_regmap_config);
5217-
if (IS_ERR(wcd->if_regmap)) {
5218-
dev_err(dev, "Failed to allocate ifc register map\n");
5219-
return PTR_ERR(wcd->if_regmap);
5220-
}
5213+
if (IS_ERR(wcd->if_regmap))
5214+
return dev_err_probe(dev, PTR_ERR(wcd->if_regmap),
5215+
"Failed to allocate ifc register map\n");
52215216

52225217
ret = wcd9335_bring_up(wcd);
52235218
if (ret) {

0 commit comments

Comments
 (0)