Skip to content

Commit 6752dbe

Browse files
Bartosz GolaszewskiLinus Walleij
authored andcommitted
pinctrl: bcm: iproc-gpio: use new GPIO line value setter callbacks
struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Link: https://lore.kernel.org/20250425-gpiochip-set-rv-pinctrl-bcm-v1-2-6b8883d79b66@linaro.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent c84c4a1 commit 6752dbe

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/pinctrl/bcm/pinctrl-iproc-gpio.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ static int iproc_gpio_get_direction(struct gpio_chip *gc, unsigned int gpio)
390390
return GPIO_LINE_DIRECTION_IN;
391391
}
392392

393-
static void iproc_gpio_set(struct gpio_chip *gc, unsigned gpio, int val)
393+
static int iproc_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
394394
{
395395
struct iproc_gpio *chip = gpiochip_get_data(gc);
396396
unsigned long flags;
@@ -400,6 +400,8 @@ static void iproc_gpio_set(struct gpio_chip *gc, unsigned gpio, int val)
400400
raw_spin_unlock_irqrestore(&chip->lock, flags);
401401

402402
dev_dbg(chip->dev, "gpio:%u set, value:%d\n", gpio, val);
403+
404+
return 0;
403405
}
404406

405407
static int iproc_gpio_get(struct gpio_chip *gc, unsigned gpio)
@@ -863,7 +865,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
863865
gc->direction_input = iproc_gpio_direction_input;
864866
gc->direction_output = iproc_gpio_direction_output;
865867
gc->get_direction = iproc_gpio_get_direction;
866-
gc->set = iproc_gpio_set;
868+
gc->set_rv = iproc_gpio_set;
867869
gc->get = iproc_gpio_get;
868870

869871
chip->pinmux_is_supported = of_property_read_bool(dev->of_node,

0 commit comments

Comments
 (0)