Skip to content

Commit 67932f6

Browse files
arighihtejun
authored andcommitted
sched_ext: Update comments replacing breather with aborting mechanism
Commit 5ebec44 ("sched_ext: Exit dispatch and move operations immediately when aborting") replaced the breather mechanism with the scx_aborting flag. Update comments removing references to the breather mechanism to avoid confusion. Signed-off-by: Andrea Righi <arighi@nvidia.com> Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent 95d1df6 commit 67932f6

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

kernel/sched/ext.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3732,7 +3732,7 @@ bool scx_rcu_cpu_stall(void)
37323732
* live-lock the system by making many CPUs target the same DSQ to the point
37333733
* where soft-lockup detection triggers. This function is called from
37343734
* soft-lockup watchdog when the triggering point is close and tries to unjam
3735-
* the system by enabling the breather and aborting the BPF scheduler.
3735+
* the system and aborting the BPF scheduler.
37363736
*/
37373737
void scx_softlockup(u32 dur_s)
37383738
{
@@ -4315,9 +4315,9 @@ static bool scx_claim_exit(struct scx_sched *sch, enum scx_exit_kind kind)
43154315
return false;
43164316

43174317
/*
4318-
* Some CPUs may be trapped in the dispatch paths. Enable breather
4319-
* immediately; otherwise, we might not even be able to get to
4320-
* scx_bypass().
4318+
* Some CPUs may be trapped in the dispatch paths. Set the aborting
4319+
* flag to break potential live-lock scenarios, ensuring we can
4320+
* successfully reach scx_bypass().
43214321
*/
43224322
WRITE_ONCE(scx_aborting, true);
43234323
return true;

0 commit comments

Comments
 (0)