Skip to content

Commit 68067f0

Browse files
Jiawen Wudavem330
authored andcommitted
net: wangxun: fix to change Rx features
Fix the issue where some Rx features cannot be changed. When using ethtool -K to turn off rx offload, it returns error and displays "Could not change any device features". And netdev->features is not assigned a new value to actually configure the hardware. Fixes: 6dbedcf ("net: libwx: Implement xx_set_features ops") Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 581073f commit 68067f0

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

  • drivers/net/ethernet/wangxun/libwx

drivers/net/ethernet/wangxun/libwx/wx_lib.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2690,12 +2690,14 @@ int wx_set_features(struct net_device *netdev, netdev_features_t features)
26902690
wx->rss_enabled = false;
26912691
}
26922692

2693+
netdev->features = features;
2694+
26932695
if (changed &
26942696
(NETIF_F_HW_VLAN_CTAG_RX |
26952697
NETIF_F_HW_VLAN_STAG_RX))
26962698
wx_set_rx_mode(netdev);
26972699

2698-
return 1;
2700+
return 0;
26992701
}
27002702
EXPORT_SYMBOL(wx_set_features);
27012703

0 commit comments

Comments
 (0)