Skip to content

Commit 680ad31

Browse files
Haoxiang Litsbogend
authored andcommitted
MIPS: Fix a reference leak bug in ip22_check_gio()
If gio_device_register fails, gio_dev_put() is required to drop the gio_dev device reference. Fixes: e84de0c ("MIPS: GIO bus support for SGI IP22/28") Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
1 parent bd94fbe commit 680ad31

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

arch/mips/sgi-ip22/ip22-gio.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,8 @@ static void ip22_check_gio(int slotno, unsigned long addr, int irq)
372372
gio_dev->resource.flags = IORESOURCE_MEM;
373373
gio_dev->irq = irq;
374374
dev_set_name(&gio_dev->dev, "%d", slotno);
375-
gio_device_register(gio_dev);
375+
if (gio_device_register(gio_dev))
376+
gio_dev_put(gio_dev);
376377
} else
377378
printk(KERN_INFO "GIO: slot %d : Empty\n", slotno);
378379
}

0 commit comments

Comments
 (0)