i2c: designware: Use better constants from units.h

andy-shev · Andi Shyti · commit 688d389cdf8c · 2025-05-19T22:23:55.000+02:00
When we use constants in a time or frequency related contexts, it's better to utilise the respective definitions that have encoded units in them. This will make code better to read and understand. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> Link: https://lore.kernel.org/r/20250416101702.2128740-1-andriy.shevchenko@linux.intel.com Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -34,7 +34,7 @@
 
 static u32 i2c_dw_get_clk_rate_khz(struct dw_i2c_dev *dev)
 {
-	return clk_get_rate(dev->clk) / KILO;
+	return clk_get_rate(dev->clk) / HZ_PER_KHZ;
 }
 
 #ifdef CONFIG_OF

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`
`35`	`35`	`static u32 i2c_dw_get_clk_rate_khz(struct dw_i2c_dev *dev)`
`36`	`36`	`{`
`37`		`- return clk_get_rate(dev->clk) / KILO;`
	`37`	`+ return clk_get_rate(dev->clk) / HZ_PER_KHZ;`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`#ifdef CONFIG_OF`