MIPS: alchemy: gpio: use new line value setter callbacks

Bartosz Golaszewski · tsbogend · commit 68bdc4dc1130 · 2025-04-27T09:21:21.000+02:00
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski &lt;bartosz.golaszewski@linaro.org&gt;
Reviewed-by: Linus Walleij &lt;linus.walleij@linaro.org&gt;
Signed-off-by: Thomas Bogendoerfer &lt;tsbogend@alpha.franken.de&gt;
diff --git a/arch/mips/alchemy/common/gpiolib.c b/arch/mips/alchemy/common/gpiolib.c
@@ -119,9 +119,11 @@ static int alchemy_gpic_get(struct gpio_chip *chip, unsigned int off)
 	return !!au1300_gpio_get_value(off + AU1300_GPIO_BASE);
 }
 
-static void alchemy_gpic_set(struct gpio_chip *chip, unsigned int off, int v)
+static int alchemy_gpic_set(struct gpio_chip *chip, unsigned int off, int v)
 {
 	au1300_gpio_set_value(off + AU1300_GPIO_BASE, v);
+
+	return 0;
 }
 
 static int alchemy_gpic_dir_input(struct gpio_chip *chip, unsigned int off)
@@ -145,7 +147,7 @@ static struct gpio_chip au1300_gpiochip = {
 	.direction_input	= alchemy_gpic_dir_input,
 	.direction_output	= alchemy_gpic_dir_output,
 	.get			= alchemy_gpic_get,
-	.set			= alchemy_gpic_set,
+	.set_rv			= alchemy_gpic_set,
 	.to_irq			= alchemy_gpic_gpio_to_irq,
 	.base			= AU1300_GPIO_BASE,
 	.ngpio			= AU1300_GPIO_NUM,

Original file line number	Diff line number	Diff line change
`@@ -119,9 +119,11 @@ static int alchemy_gpic_get(struct gpio_chip *chip, unsigned int off)`
`119`	`119`	`return !!au1300_gpio_get_value(off + AU1300_GPIO_BASE);`
`120`	`120`	`}`
`121`	`121`
`122`		`-static void alchemy_gpic_set(struct gpio_chip *chip, unsigned int off, int v)`
	`122`	`+static int alchemy_gpic_set(struct gpio_chip *chip, unsigned int off, int v)`
`123`	`123`	`{`
`124`	`124`	`au1300_gpio_set_value(off + AU1300_GPIO_BASE, v);`
	`125`	`+`
	`126`	`+ return 0;`
`125`	`127`	`}`
`126`	`128`
`127`	`129`	`static int alchemy_gpic_dir_input(struct gpio_chip *chip, unsigned int off)`
`@@ -145,7 +147,7 @@ static struct gpio_chip au1300_gpiochip = {`
`145`	`147`	`.direction_input = alchemy_gpic_dir_input,`
`146`	`148`	`.direction_output = alchemy_gpic_dir_output,`
`147`	`149`	`.get = alchemy_gpic_get,`
`148`		`- .set = alchemy_gpic_set,`
	`150`	`+ .set_rv = alchemy_gpic_set,`
`149`	`151`	`.to_irq = alchemy_gpic_gpio_to_irq,`
`150`	`152`	`.base = AU1300_GPIO_BASE,`
`151`	`153`	`.ngpio = AU1300_GPIO_NUM,`