regulator: scmi: Fix refcount leak in scmi_regulator_probe

Yuuoniy · broonie · commit 68d6c8476fd4 · 2022-05-17T11:58:13.000+01:00
of_find_node_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 0fbeae7 ("regulator: add SCMI driver") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220516074433.32433-1-linmq006@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c
@@ -352,7 +352,7 @@ static int scmi_regulator_probe(struct scmi_device *sdev)
 			return ret;
 		}
 	}
-
+	of_node_put(np);
 	/*
 	 * Register a regulator for each valid regulator-DT-entry that we
 	 * can successfully reach via SCMI and has a valid associated voltage

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ static int scmi_regulator_probe(struct scmi_device *sdev)`
`352`	`352`	`return ret;`
`353`	`353`	`}`
`354`	`354`	`}`
`355`		`-`
	`355`	`+ of_node_put(np);`
`356`	`356`	`/*`
`357`	`357`	`* Register a regulator for each valid regulator-DT-entry that we`
`358`	`358`	`* can successfully reach via SCMI and has a valid associated voltage`