Skip to content

Commit 68e6243

Browse files
JasonYanHwtytso
authored andcommitted
ext4: rename two functions with 'check'
The naming styles are different for some functions with 'check' in their names. Some of them are like: ext4_check_quota_consistency ext4_check_test_dummy_encryption ext4_check_opt_consistency ext4_check_descriptors ext4_check_feature_compatibility While the others looks like below: ext4_geometry_check ext4_journal_data_mode_check This is not a big deal and boils down to personal preference. But I'd like to make them consistent. Signed-off-by: Jason Yan <yanaijie@huawei.com> Link: https://lore.kernel.org/r/20230323140517.1070239-6-yanaijie@huawei.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent dcbf875 commit 68e6243

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

fs/ext4/super.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4713,7 +4713,7 @@ static int ext4_check_feature_compatibility(struct super_block *sb,
47134713
return 0;
47144714
}
47154715

4716-
static int ext4_geometry_check(struct super_block *sb,
4716+
static int ext4_check_geometry(struct super_block *sb,
47174717
struct ext4_super_block *es)
47184718
{
47194719
struct ext4_sb_info *sbi = EXT4_SB(sb);
@@ -4922,7 +4922,7 @@ static int ext4_load_and_init_journal(struct super_block *sb,
49224922
return -EINVAL;
49234923
}
49244924

4925-
static int ext4_journal_data_mode_check(struct super_block *sb)
4925+
static int ext4_check_journal_data_mode(struct super_block *sb)
49264926
{
49274927
if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA) {
49284928
printk_once(KERN_WARNING "EXT4-fs: Warning: mounting with "
@@ -5162,7 +5162,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
51625162
if (ext4_encoding_init(sb, es))
51635163
goto failed_mount;
51645164

5165-
if (ext4_journal_data_mode_check(sb))
5165+
if (ext4_check_journal_data_mode(sb))
51665166
goto failed_mount;
51675167

51685168
sb->s_flags = (sb->s_flags & ~SB_POSIXACL) |
@@ -5264,7 +5264,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
52645264
goto failed_mount;
52655265
}
52665266

5267-
if (ext4_geometry_check(sb, es))
5267+
if (ext4_check_geometry(sb, es))
52685268
goto failed_mount;
52695269

52705270
timer_setup(&sbi->s_err_report, print_daily_error_info, 0);

0 commit comments

Comments
 (0)