drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init()

Wang Li · Chun-Kuang Hu · commit 69777e6ca396 · 2021-05-14T07:29:07.000+08:00
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot &lt;hulkci@huawei.com&gt;
Signed-off-by: Wang Li &lt;wangli74@huawei.com&gt;
Signed-off-by: Chun-Kuang Hu &lt;chunkuang.hu@kernel.org&gt;
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
@@ -260,7 +260,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
 		drm_connector_list_iter_end(&conn_iter);
 	}
 
-	ret = pm_runtime_get_sync(crtc->dev->dev);
+	ret = pm_runtime_resume_and_get(crtc->dev->dev);
 	if (ret < 0) {
 		DRM_ERROR("Failed to enable power domain: %d\n", ret);
 		return ret;

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)`
`260`	`260`	`drm_connector_list_iter_end(&conn_iter);`
`261`	`261`	`}`
`262`	`262`
`263`		`- ret = pm_runtime_get_sync(crtc->dev->dev);`
	`263`	`+ ret = pm_runtime_resume_and_get(crtc->dev->dev);`
`264`	`264`	`if (ret < 0) {`
`265`	`265`	`DRM_ERROR("Failed to enable power domain: %d\n", ret);`
`266`	`266`	`return ret;`