Skip to content

Commit 6985c5e

Browse files
tombarobertfoss
authored andcommitted
drm/bridge: lt8912b: Manually disable HPD only if it was enabled
lt8912b only calls drm_bridge_hpd_enable() if it creates a connector and the next bridge has DRM_BRIDGE_OP_HPD set. However, when calling drm_bridge_hpd_disable() it misses checking if a connector was created, calling drm_bridge_hpd_disable() even if HPD was never enabled. I don't see any issues caused by this wrong call, though. Add the check to avoid wrongly calling drm_bridge_hpd_disable(). Fixes: 3b0a01a ("drm/bridge: lt8912b: Add hot plug detection") Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> Reviewed-by: Robert Foss <rfoss@kernel.org> Signed-off-by: Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230804-lt8912b-v1-3-c542692c6a2f@ideasonboard.com
1 parent 4428399 commit 6985c5e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/bridge/lontium-lt8912b.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ static void lt8912_bridge_detach(struct drm_bridge *bridge)
587587

588588
lt8912_hard_power_off(lt);
589589

590-
if (lt->hdmi_port->ops & DRM_BRIDGE_OP_HPD)
590+
if (lt->connector.dev && lt->hdmi_port->ops & DRM_BRIDGE_OP_HPD)
591591
drm_bridge_hpd_disable(lt->hdmi_port);
592592
}
593593

0 commit comments

Comments
 (0)