Skip to content

Commit 698cdcb

Browse files
Chun-Kuang HuAngeloGioacchino Del Regno
authored andcommitted
soc: mediatek: cmdq: Add cmdq_pkt_jump_rel() helper function
cmdq_pkt_jump_rel() append relative jump command to the packet. Relative jump change PC to the target address with offset from current PC. Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20240222154120.16959-5-chunkuang.hu@kernel.org Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
1 parent 7218be3 commit 698cdcb

2 files changed

Lines changed: 29 additions & 0 deletions

File tree

drivers/soc/mediatek/mtk-cmdq-helper.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,16 @@ int cmdq_pkt_jump_abs(struct cmdq_pkt *pkt, dma_addr_t addr, u8 shift_pa)
404404
}
405405
EXPORT_SYMBOL(cmdq_pkt_jump_abs);
406406

407+
int cmdq_pkt_jump_rel(struct cmdq_pkt *pkt, s32 offset, u8 shift_pa)
408+
{
409+
struct cmdq_instruction inst = { {0} };
410+
411+
inst.op = CMDQ_CODE_JUMP;
412+
inst.value = (u32)offset >> shift_pa;
413+
return cmdq_pkt_append_command(pkt, inst);
414+
}
415+
EXPORT_SYMBOL(cmdq_pkt_jump_rel);
416+
407417
int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
408418
{
409419
struct cmdq_instruction inst = { {0} };

include/linux/soc/mediatek/mtk-cmdq.h

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,20 @@ static inline int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr, u8 shift_
267267
return cmdq_pkt_jump_abs(pkt, addr, shift_pa);
268268
}
269269

270+
/**
271+
* cmdq_pkt_jump_rel() - Append jump command to the CMDQ packet, ask GCE
272+
* to execute an instruction that change current thread
273+
* PC to a physical address with relative offset. The
274+
* target address should contains more instruction.
275+
* @pkt: the CMDQ packet
276+
* @offset: relative offset of target instruction buffer from current PC.
277+
* @shift_pa: shift bits of physical address in CMDQ instruction. This value
278+
* is got by cmdq_get_shift_pa().
279+
*
280+
* Return: 0 for success; else the error code is returned
281+
*/
282+
int cmdq_pkt_jump_rel(struct cmdq_pkt *pkt, s32 offset, u8 shift_pa);
283+
270284
/**
271285
* cmdq_pkt_finalize() - Append EOC and jump command to pkt.
272286
* @pkt: the CMDQ packet
@@ -393,6 +407,11 @@ static inline int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr, u8 shift_
393407
return -EINVAL;
394408
}
395409

410+
static inline int cmdq_pkt_jump_rel(struct cmdq_pkt *pkt, s32 offset, u8 shift_pa)
411+
{
412+
return -EINVAL;
413+
}
414+
396415
static inline int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
397416
{
398417
return -EINVAL;

0 commit comments

Comments
 (0)