scsi: ufs: core: Conversion to bool not necessary

bragathemanick · martinkpetersen · commit 6997283f64d9 · 2023-10-24T22:44:35.000-04:00
A logical evaluation already results in bool. There is no need for using a ternary operator based evaluation and bool conversion of the outcome. Issue identified using boolconv.cocci Coccinelle semantic patch. Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> Link: https://lore.kernel.org/r/20231024183401.48888-1-bragathemanick0908@gmail.com Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
@@ -2406,7 +2406,7 @@ static inline bool ufshcd_ready_for_uic_cmd(struct ufs_hba *hba)
 	int ret = read_poll_timeout(ufshcd_readl, val, val & UIC_COMMAND_READY,
 				    500, UIC_CMD_TIMEOUT * 1000, false, hba,
 				    REG_CONTROLLER_STATUS);
-	return ret == 0 ? true : false;
+	return ret == 0;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -2406,7 +2406,7 @@ static inline bool ufshcd_ready_for_uic_cmd(struct ufs_hba *hba)`
`2406`	`2406`	`int ret = read_poll_timeout(ufshcd_readl, val, val & UIC_COMMAND_READY,`
`2407`	`2407`	`500, UIC_CMD_TIMEOUT * 1000, false, hba,`
`2408`	`2408`	`REG_CONTROLLER_STATUS);`
`2409`		`- return ret == 0 ? true : false;`
	`2409`	`+ return ret == 0;`
`2410`	`2410`	`}`
`2411`	`2411`
`2412`	`2412`	`/**`