Skip to content

Commit 699fcfb

Browse files
Chaitanya Kulkarniaxboe
authored andcommitted
md: ignore discard return value
__blkdev_issue_discard() always returns 0, making all error checking at call sites dead code. Simplify md to only check !discard_bio by ignoring the __blkdev_issue_discard() value. Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 81e7223 commit 699fcfb

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/md/md.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9179,8 +9179,8 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev,
91799179
{
91809180
struct bio *discard_bio = NULL;
91819181

9182-
if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO,
9183-
&discard_bio) || !discard_bio)
9182+
__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, &discard_bio);
9183+
if (!discard_bio)
91849184
return;
91859185

91869186
bio_chain(discard_bio, bio);

0 commit comments

Comments
 (0)