Skip to content

Commit 6a293b6

Browse files
antheasij-intel
authored andcommitted
HID: asus: use same report_id in response
Currently, asus_kbd_get_functions prods the device using feature report report_id, but then is hardcoded to check the response through FEATURE_KBD_REPORT_ID. This only works if report_id is that value (currently true). So, use report_id in the response as well to maintain functionality if that value changes in the future. Reviewed-by: Denis Benato <benato.denis96@gmail.com> Acked-by: Benjamin Tissoires <bentiss@kernel.org> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> Link: https://patch.msgid.link/20260122075044.5070-4-lkml@antheas.dev Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent 4ac51da commit 6a293b6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/hid/hid-asus.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ static int asus_kbd_get_functions(struct hid_device *hdev,
424424
if (!readbuf)
425425
return -ENOMEM;
426426

427-
ret = hid_hw_raw_request(hdev, FEATURE_KBD_REPORT_ID, readbuf,
427+
ret = hid_hw_raw_request(hdev, report_id, readbuf,
428428
FEATURE_KBD_REPORT_SIZE, HID_FEATURE_REPORT,
429429
HID_REQ_GET_REPORT);
430430
if (ret < 0) {

0 commit comments

Comments
 (0)