Skip to content

Commit 6a8b7e8

Browse files
wb-zjp846396jenswi-linaro
authored andcommitted
tee: optee: Use kmemdup() to replace kmalloc + memcpy
Use kmemdup rather than duplicating its implementation. ./drivers/tee/optee/smc_abi.c:1542:12-19: WARNING opportunity for kmemdup. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5480 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Reviewed-by: Sumit Garg <sumit.garg@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
1 parent f1fcbaa commit 6a8b7e8

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/tee/optee/smc_abi.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1539,12 +1539,11 @@ static int optee_load_fw(struct platform_device *pdev,
15391539
* This uses the GFP_DMA flag to ensure we are allocated memory in the
15401540
* 32-bit space since TF-A cannot map memory beyond the 32-bit boundary.
15411541
*/
1542-
data_buf = kmalloc(fw->size, GFP_KERNEL | GFP_DMA);
1542+
data_buf = kmemdup(fw->data, fw->size, GFP_KERNEL | GFP_DMA);
15431543
if (!data_buf) {
15441544
rc = -ENOMEM;
15451545
goto fw_err;
15461546
}
1547-
memcpy(data_buf, fw->data, fw->size);
15481547
data_pa = virt_to_phys(data_buf);
15491548
reg_pair_from_64(&data_pa_high, &data_pa_low, data_pa);
15501549
reg_pair_from_64(&data_size_high, &data_size_low, data_size);

0 commit comments

Comments
 (0)