Skip to content

Commit 6ac433f

Browse files
compudjakpm00
authored andcommitted
mm: rename cpu_bitmap field to flexible_array
The cpu_bitmap flexible array now contains more than just the cpu_bitmap. In preparation for changing the static mm_struct definitions to cover for the additional space required, change the cpu_bitmap type from "unsigned long" to "char", require an unsigned long alignment of the flexible array, and rename the field from "cpu_bitmap" to "flexible_array". Introduce the MM_STRUCT_FLEXIBLE_ARRAY_INIT macro to statically initialize the flexible array. This covers the init_mm and efi_mm static definitions. This is a preparation step for fixing the missing mm_cid size for static mm_struct definitions. Link: https://lkml.kernel.org/r/20251224173358.647691-3-mathieu.desnoyers@efficios.com Fixes: af7f588 ("sched: Introduce per-memory-map concurrency ID") Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Reviewed-by: Thomas Gleixner <tglx@kernel.org> Cc: Mark Brown <broonie@kernel.org> Cc: Aboorva Devarajan <aboorvad@linux.ibm.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Baolin Wang <baolin.wang@linux.alibaba.com> Cc: Christan König <christian.koenig@amd.com> Cc: Christian Brauner <brauner@kernel.org> Cc: Christoph Lameter <cl@linux.com> Cc: David Hildenbrand <david@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Dennis Zhou <dennis@kernel.org> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: "Liam R . Howlett" <liam.howlett@oracle.com> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> Cc: Martin Liu <liumartin@google.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mateusz Guzik <mjguzik@gmail.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Miaohe Lin <linmiaohe@huawei.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Mike Rapoport <rppt@kernel.org> Cc: "Paul E. McKenney" <paulmck@kernel.org> Cc: Roman Gushchin <roman.gushchin@linux.dev> Cc: SeongJae Park <sj@kernel.org> Cc: Shakeel Butt <shakeel.butt@linux.dev> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Suren Baghdasaryan <surenb@google.com> Cc: Sweet Tea Dorminy <sweettea-kernel@dorminy.me> Cc: Tejun Heo <tj@kernel.org> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Wei Yang <richard.weiyang@gmail.com> Cc: Yu Zhao <yuzhao@google.com> Cc: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 12a6ddf commit 6ac433f

3 files changed

Lines changed: 11 additions & 6 deletions

File tree

drivers/firmware/efi/efi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@ struct mm_struct efi_mm = {
7474
.page_table_lock = __SPIN_LOCK_UNLOCKED(efi_mm.page_table_lock),
7575
.mmlist = LIST_HEAD_INIT(efi_mm.mmlist),
7676
.user_ns = &init_user_ns,
77-
.cpu_bitmap = { [BITS_TO_LONGS(NR_CPUS)] = 0},
7877
#ifdef CONFIG_SCHED_MM_CID
7978
.mm_cid.lock = __RAW_SPIN_LOCK_UNLOCKED(efi_mm.mm_cid.lock),
8079
#endif
80+
.flexible_array = MM_STRUCT_FLEXIBLE_ARRAY_INIT,
8181
};
8282

8383
struct workqueue_struct *efi_rts_wq;

include/linux/mm_types.h

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1329,7 +1329,7 @@ struct mm_struct {
13291329
* The mm_cpumask needs to be at the end of mm_struct, because it
13301330
* is dynamically sized based on nr_cpu_ids.
13311331
*/
1332-
unsigned long cpu_bitmap[];
1332+
char flexible_array[] __aligned(__alignof__(unsigned long));
13331333
};
13341334

13351335
/* Copy value to the first system word of mm flags, non-atomically. */
@@ -1366,19 +1366,24 @@ static inline void __mm_flags_set_mask_bits_word(struct mm_struct *mm,
13661366
MT_FLAGS_USE_RCU)
13671367
extern struct mm_struct init_mm;
13681368

1369+
#define MM_STRUCT_FLEXIBLE_ARRAY_INIT \
1370+
{ \
1371+
[0 ... sizeof(cpumask_t)-1] = 0 \
1372+
}
1373+
13691374
/* Pointer magic because the dynamic array size confuses some compilers. */
13701375
static inline void mm_init_cpumask(struct mm_struct *mm)
13711376
{
13721377
unsigned long cpu_bitmap = (unsigned long)mm;
13731378

1374-
cpu_bitmap += offsetof(struct mm_struct, cpu_bitmap);
1379+
cpu_bitmap += offsetof(struct mm_struct, flexible_array);
13751380
cpumask_clear((struct cpumask *)cpu_bitmap);
13761381
}
13771382

13781383
/* Future-safe accessor for struct mm_struct's cpu_vm_mask. */
13791384
static inline cpumask_t *mm_cpumask(struct mm_struct *mm)
13801385
{
1381-
return (struct cpumask *)&mm->cpu_bitmap;
1386+
return (struct cpumask *)&mm->flexible_array;
13821387
}
13831388

13841389
#ifdef CONFIG_LRU_GEN
@@ -1469,7 +1474,7 @@ static inline cpumask_t *mm_cpus_allowed(struct mm_struct *mm)
14691474
{
14701475
unsigned long bitmap = (unsigned long)mm;
14711476

1472-
bitmap += offsetof(struct mm_struct, cpu_bitmap);
1477+
bitmap += offsetof(struct mm_struct, flexible_array);
14731478
/* Skip cpu_bitmap */
14741479
bitmap += cpumask_size();
14751480
return (struct cpumask *)bitmap;

mm/init-mm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ struct mm_struct init_mm = {
4747
#ifdef CONFIG_SCHED_MM_CID
4848
.mm_cid.lock = __RAW_SPIN_LOCK_UNLOCKED(init_mm.mm_cid.lock),
4949
#endif
50-
.cpu_bitmap = CPU_BITS_NONE,
50+
.flexible_array = MM_STRUCT_FLEXIBLE_ARRAY_INIT,
5151
INIT_MM_CONTEXT(init_mm)
5252
};
5353

0 commit comments

Comments
 (0)