kcm: Destroy mutex in kcm_exit_net()

Shigeru Yoshida · Paolo Abeni · commit 6ad40b36cd3b · 2023-09-05T10:12:03.000+02:00
kcm_exit_net() should call mutex_destroy() on knet->mutex. This is especially needed if CONFIG_DEBUG_MUTEXES is enabled. Fixes: ab7ac4e ("kcm: Kernel Connection Multiplexor module") Signed-off-by: Shigeru Yoshida <syoshida@redhat.com> Link: https://lore.kernel.org/r/20230902170708.1727999-1-syoshida@redhat.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c
@@ -1859,6 +1859,8 @@ static __net_exit void kcm_exit_net(struct net *net)
 	 * that all multiplexors and psocks have been destroyed.
 	 */
 	WARN_ON(!list_empty(&knet->mux_list));
+
+	mutex_destroy(&knet->mutex);
 }
 
 static struct pernet_operations kcm_net_ops = {

Original file line number	Diff line number	Diff line change
`@@ -1859,6 +1859,8 @@ static __net_exit void kcm_exit_net(struct net *net)`
`1859`	`1859`	`* that all multiplexors and psocks have been destroyed.`
`1860`	`1860`	`*/`
`1861`	`1861`	`WARN_ON(!list_empty(&knet->mux_list));`
	`1862`	`+`
	`1863`	`+ mutex_destroy(&knet->mutex);`
`1862`	`1864`	`}`
`1863`	`1865`
`1864`	`1866`	`static struct pernet_operations kcm_net_ops = {`