Skip to content

Commit 6b0d812

Browse files
superm1alexdeucher
authored andcommitted
drm/amd: Disable MES LR compute W/A
A workaround was introduced in commit 1fb7107 ("drm/amdgpu: Enable MES lr_compute_wa by default") to help with some hangs observed in gfx1151. This WA didn't fully fix the issue. It was actually fixed by adjusting the VGPR size to the correct value that matched the hardware in commit b42f3bf ("drm/amdkfd: bump minimum vgpr size for gfx1151"). There are reports of instability on other products with newer GC microcode versions, and I believe they're caused by this workaround. As we don't need the workaround any more, remove it. Fixes: b42f3bf ("drm/amdkfd: bump minimum vgpr size for gfx1151") Acked-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit 9973e64) Cc: stable@vger.kernel.org
1 parent b57c4ec commit 6b0d812

2 files changed

Lines changed: 0 additions & 10 deletions

File tree

drivers/gpu/drm/amd/amdgpu/mes_v11_0.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -720,11 +720,6 @@ static int mes_v11_0_set_hw_resources(struct amdgpu_mes *mes)
720720
mes_set_hw_res_pkt.enable_reg_active_poll = 1;
721721
mes_set_hw_res_pkt.enable_level_process_quantum_check = 1;
722722
mes_set_hw_res_pkt.oversubscription_timer = 50;
723-
if ((mes->adev->mes.sched_version & AMDGPU_MES_VERSION_MASK) >= 0x7f)
724-
mes_set_hw_res_pkt.enable_lr_compute_wa = 1;
725-
else
726-
dev_info_once(mes->adev->dev,
727-
"MES FW version must be >= 0x7f to enable LR compute workaround.\n");
728723

729724
if (amdgpu_mes_log_enable) {
730725
mes_set_hw_res_pkt.enable_mes_event_int_logging = 1;

drivers/gpu/drm/amd/amdgpu/mes_v12_0.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -779,11 +779,6 @@ static int mes_v12_0_set_hw_resources(struct amdgpu_mes *mes, int pipe)
779779
mes_set_hw_res_pkt.use_different_vmid_compute = 1;
780780
mes_set_hw_res_pkt.enable_reg_active_poll = 1;
781781
mes_set_hw_res_pkt.enable_level_process_quantum_check = 1;
782-
if ((mes->adev->mes.sched_version & AMDGPU_MES_VERSION_MASK) >= 0x82)
783-
mes_set_hw_res_pkt.enable_lr_compute_wa = 1;
784-
else
785-
dev_info_once(adev->dev,
786-
"MES FW version must be >= 0x82 to enable LR compute workaround.\n");
787782

788783
/*
789784
* Keep oversubscribe timer for sdma . When we have unmapped doorbell

0 commit comments

Comments
 (0)