Skip to content

Commit 6b0eadf

Browse files
andredJassi Brar
authored andcommitted
mailbox: exynos: drop unneeded runtime pointer (pclk)
pclk is not needed past probe(), just drop it. This saves a little bit of runtime memory. Signed-off-by: André Draszik <andre.draszik@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
1 parent 6733270 commit 6b0eadf

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

drivers/mailbox/exynos-mailbox.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,10 @@
3535
* struct exynos_mbox - driver's private data.
3636
* @regs: mailbox registers base address.
3737
* @mbox: pointer to the mailbox controller.
38-
* @pclk: pointer to the mailbox peripheral clock.
3938
*/
4039
struct exynos_mbox {
4140
void __iomem *regs;
4241
struct mbox_controller *mbox;
43-
struct clk *pclk;
4442
};
4543

4644
static int exynos_mbox_send_data(struct mbox_chan *chan, void *data)
@@ -100,6 +98,7 @@ static int exynos_mbox_probe(struct platform_device *pdev)
10098
struct exynos_mbox *exynos_mbox;
10199
struct mbox_controller *mbox;
102100
struct mbox_chan *chans;
101+
struct clk *pclk;
103102
int i;
104103

105104
exynos_mbox = devm_kzalloc(dev, sizeof(*exynos_mbox), GFP_KERNEL);
@@ -119,9 +118,9 @@ static int exynos_mbox_probe(struct platform_device *pdev)
119118
if (IS_ERR(exynos_mbox->regs))
120119
return PTR_ERR(exynos_mbox->regs);
121120

122-
exynos_mbox->pclk = devm_clk_get_enabled(dev, "pclk");
123-
if (IS_ERR(exynos_mbox->pclk))
124-
return dev_err_probe(dev, PTR_ERR(exynos_mbox->pclk),
121+
pclk = devm_clk_get_enabled(dev, "pclk");
122+
if (IS_ERR(pclk))
123+
return dev_err_probe(dev, PTR_ERR(pclk),
125124
"Failed to enable clock.\n");
126125

127126
mbox->num_chans = EXYNOS_MBOX_CHAN_COUNT;

0 commit comments

Comments
 (0)