dm integrity: call kmem_cache_destroy() in dm_integrity_init() error path

Mike Snitzer · Mike Snitzer · commit 6b79a428c027 · 2023-04-04T13:39:25.000-04:00
Otherwise the journal_io_cache will leak if dm_register_target() fails.

Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer &lt;snitzer@kernel.org&gt;
diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
@@ -4703,11 +4703,13 @@ static int __init dm_integrity_init(void)
 	}
 
 	r = dm_register_target(&integrity_target);
-
-	if (r < 0)
+	if (r < 0) {
 		DMERR("register failed %d", r);
+		kmem_cache_destroy(journal_io_cache);
+		return r;
+	}
 
-	return r;
+	return 0;
 }
 
 static void __exit dm_integrity_exit(void)

Original file line number	Diff line number	Diff line change
`@@ -4703,11 +4703,13 @@ static int __init dm_integrity_init(void)`
`4703`	`4703`	`}`
`4704`	`4704`
`4705`	`4705`	`r = dm_register_target(&integrity_target);`
`4706`		`-`
`4707`		`- if (r < 0)`
	`4706`	`+ if (r < 0) {`
`4708`	`4707`	`DMERR("register failed %d", r);`
	`4708`	`+ kmem_cache_destroy(journal_io_cache);`
	`4709`	`+ return r;`
	`4710`	`+ }`
`4709`	`4711`
`4710`		`- return r;`
	`4712`	`+ return 0;`
`4711`	`4713`	`}`
`4712`	`4714`
`4713`	`4715`	`static void __exit dm_integrity_exit(void)`