PM / devfreq: mediatek: unlock on error in mtk_ccifreq_target()

Dan Carpenter · chanwoochoi · commit 6c29e29e4d7f · 2023-10-17T17:54:01.000+09:00
Call mutex_unlock(&drv->reg_lock) before returning the error code. Link: https://lore.kernel.org/all/1bada9b2-d276-4123-bfdf-03d165569543@moroto.mountain/ Fixes: d280560 ("PM / devfreq: mediatek: protect oop in critical session") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
diff --git a/drivers/devfreq/mtk-cci-devfreq.c b/drivers/devfreq/mtk-cci-devfreq.c
@@ -146,7 +146,8 @@ static int mtk_ccifreq_target(struct device *dev, unsigned long *freq,
 	opp = devfreq_recommended_opp(dev, &opp_rate, 1);
 	if (IS_ERR(opp)) {
 		dev_err(dev, "failed to find opp for freq: %ld\n", opp_rate);
-		return PTR_ERR(opp);
+		ret = PTR_ERR(opp);
+		goto out_unlock;
 	}
 
 	voltage = dev_pm_opp_get_voltage(opp);

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,8 @@ static int mtk_ccifreq_target(struct device dev, unsigned long freq,`
`146`	`146`	`opp = devfreq_recommended_opp(dev, &opp_rate, 1);`
`147`	`147`	`if (IS_ERR(opp)) {`
`148`	`148`	`dev_err(dev, "failed to find opp for freq: %ld\n", opp_rate);`
`149`		`- return PTR_ERR(opp);`
	`149`	`+ ret = PTR_ERR(opp);`
	`150`	`+ goto out_unlock;`
`150`	`151`	`}`
`151`	`152`
`152`	`153`	`voltage = dev_pm_opp_get_voltage(opp);`