Skip to content

Commit 6c7860a

Browse files
Dan Carpentermiquelraynal
authored andcommitted
mtd: spi-nor: hisi-sfc: fix refcounting bug in hisi_spi_nor_register_all()
This was converted to a _scoped() loop but this of_node_put() was accidentally left behind which is a double free. Fixes: aa8cb72 ("mtd: spi-nor: hisi-sfc: Simplify with scoped for each OF child loop") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Pratyush Yadav <pratyush@kernel.org> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
1 parent e82269e commit 6c7860a

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/mtd/spi-nor/controllers/hisi-sfc.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,6 @@ static int hisi_spi_nor_register_all(struct hifmc_host *host)
403403

404404
if (host->num_chip == HIFMC_MAX_CHIP_NUM) {
405405
dev_warn(dev, "Flash device number exceeds the maximum chipselect number\n");
406-
of_node_put(np);
407406
break;
408407
}
409408
}

0 commit comments

Comments
 (0)