Skip to content

Commit 6cf0981

Browse files
Yang Yingliangjoergroedel
authored andcommitted
iommu/amd: Fix pci device refcount leak in ppr_notifier()
As comment of pci_get_domain_bus_and_slot() says, it returns a pci device with refcount increment, when finish using it, the caller must decrement the reference count by calling pci_dev_put(). So call it before returning from ppr_notifier() to avoid refcount leak. Fixes: daae2d2 ("iommu/amd: Don't copy GCR3 table root pointer") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20221118093604.216371-1-yangyingliang@huawei.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 1198d23 commit 6cf0981

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/iommu/amd/iommu_v2.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,7 @@ static int ppr_notifier(struct notifier_block *nb, unsigned long e, void *data)
587587
put_device_state(dev_state);
588588

589589
out:
590+
pci_dev_put(pdev);
590591
return ret;
591592
}
592593

0 commit comments

Comments
 (0)