macintosh/macio-adb: add missing iounmap() on error in macio_init()

Yang Yingliang · mpe · commit 6db51ff90536 · 2023-10-19T17:16:20.000+11:00
Add missing iounmap(), if request_irq() fails. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20230105064145.3879356-1-yangyingliang@huawei.com
diff --git a/drivers/macintosh/macio-adb.c b/drivers/macintosh/macio-adb.c
@@ -123,6 +123,7 @@ int macio_init(void)
 	irq = irq_of_parse_and_map(adbs, 0);
 	of_node_put(adbs);
 	if (request_irq(irq, macio_adb_interrupt, 0, "ADB", (void *)0)) {
+		iounmap(adb);
 		printk(KERN_ERR "ADB: can't get irq %d\n", irq);
 		return -EAGAIN;
 	}

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,7 @@ int macio_init(void)`
`123`	`123`	`irq = irq_of_parse_and_map(adbs, 0);`
`124`	`124`	`of_node_put(adbs);`
`125`	`125`	`if (request_irq(irq, macio_adb_interrupt, 0, "ADB", (void *)0)) {`
	`126`	`+ iounmap(adb);`
`126`	`127`	`printk(KERN_ERR "ADB: can't get irq %d\n", irq);`
`127`	`128`	`return -EAGAIN;`
`128`	`129`	`}`