Skip to content

Commit 6dd3f08

Browse files
lumagandersson
authored andcommitted
soc: qcom: llcc: use deciman integers for bit shift values
As pointed out by Konrad Dybcio, we generally should be using decimal numbers to represent bit positions / bit shifts rather than hex numbers. Use decimals for consistency. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/r/20241026-sar2130p-llcc-v3-2-2a58fa1b4d12@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 53b3e2e commit 6dd3f08

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

drivers/soc/qcom/llcc-qcom.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@
2727
#define ACT_CTRL_OPCODE_ACTIVATE BIT(0)
2828
#define ACT_CTRL_OPCODE_DEACTIVATE BIT(1)
2929
#define ACT_CTRL_ACT_TRIG BIT(0)
30-
#define ACT_CTRL_OPCODE_SHIFT 0x01
31-
#define ATTR1_PROBE_TARGET_WAYS_SHIFT 0x02
32-
#define ATTR1_FIXED_SIZE_SHIFT 0x03
33-
#define ATTR1_PRIORITY_SHIFT 0x04
34-
#define ATTR1_MAX_CAP_SHIFT 0x10
30+
#define ACT_CTRL_OPCODE_SHIFT 1
31+
#define ATTR1_PROBE_TARGET_WAYS_SHIFT 2
32+
#define ATTR1_FIXED_SIZE_SHIFT 3
33+
#define ATTR1_PRIORITY_SHIFT 4
34+
#define ATTR1_MAX_CAP_SHIFT 16
3535
#define ATTR0_RES_WAYS_MASK GENMASK(15, 0)
3636
#define ATTR0_BONUS_WAYS_MASK GENMASK(31, 16)
37-
#define ATTR0_BONUS_WAYS_SHIFT 0x10
37+
#define ATTR0_BONUS_WAYS_SHIFT 16
3838
#define LLCC_STATUS_READ_DELAY 100
3939

4040
#define CACHE_LINE_SIZE_SHIFT 6

0 commit comments

Comments
 (0)