rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram

Yuan Can · alexandrebelloni · commit 6ddabcb10628 · 2022-05-18T14:52:17.000+02:00
The hw_srnprot needs to be unmapped when gamecube_rtc_read_offset_from_sram returns. Fixs: 8655940 (rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U) Signed-off-by: Yuan Can <yuancan@huawei.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20220511071354.46202-1-yuancan@huawei.com
diff --git a/drivers/rtc/rtc-gamecube.c b/drivers/rtc/rtc-gamecube.c
@@ -267,6 +267,7 @@ static int gamecube_rtc_read_offset_from_sram(struct priv *d)
 	ret = regmap_read(d->regmap, RTC_SRAM_BIAS, &d->rtc_bias);
 	if (ret) {
 		pr_err("failed to get the RTC bias\n");
+		iounmap(hw_srnprot);
 		return -1;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -267,6 +267,7 @@ static int gamecube_rtc_read_offset_from_sram(struct priv *d)`
`267`	`267`	`ret = regmap_read(d->regmap, RTC_SRAM_BIAS, &d->rtc_bias);`
`268`	`268`	`if (ret) {`
`269`	`269`	`pr_err("failed to get the RTC bias\n");`
	`270`	`+ iounmap(hw_srnprot);`
`270`	`271`	`return -1;`
`271`	`272`	`}`
`272`	`273`