Skip to content

Commit 6e0b939

Browse files
committed
Merge tag 'x86_microcode_for_v6.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull x86 microcode updates from Borislav Petkov: - Correct minor issues after the microcode revision reporting sanitization * tag 'x86_microcode_for_v6.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: x86/microcode/intel: Set new revision only after a successful update x86/microcode/intel: Remove redundant microcode late updated message
2 parents 1dee7f5 + 9c21ea5 commit 6e0b939

1 file changed

Lines changed: 7 additions & 13 deletions

File tree

  • arch/x86/kernel/cpu/microcode

arch/x86/kernel/cpu/microcode/intel.c

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -370,14 +370,14 @@ static __init struct microcode_intel *get_microcode_blob(struct ucode_cpu_info *
370370
{
371371
struct cpio_data cp;
372372

373+
intel_collect_cpu_info(&uci->cpu_sig);
374+
373375
if (!load_builtin_intel_microcode(&cp))
374376
cp = find_microcode_in_initrd(ucode_path);
375377

376378
if (!(cp.data && cp.size))
377379
return NULL;
378380

379-
intel_collect_cpu_info(&uci->cpu_sig);
380-
381381
return scan_microcode(cp.data, cp.size, uci, save);
382382
}
383383

@@ -410,13 +410,13 @@ void __init load_ucode_intel_bsp(struct early_load_data *ed)
410410
{
411411
struct ucode_cpu_info uci;
412412

413-
ed->old_rev = intel_get_microcode_revision();
414-
415413
uci.mc = get_microcode_blob(&uci, false);
416-
if (uci.mc && apply_microcode_early(&uci) == UCODE_UPDATED)
417-
ucode_patch_va = UCODE_BSP_LOADED;
414+
ed->old_rev = uci.cpu_sig.rev;
418415

419-
ed->new_rev = uci.cpu_sig.rev;
416+
if (uci.mc && apply_microcode_early(&uci) == UCODE_UPDATED) {
417+
ucode_patch_va = UCODE_BSP_LOADED;
418+
ed->new_rev = uci.cpu_sig.rev;
419+
}
420420
}
421421

422422
void load_ucode_intel_ap(void)
@@ -457,12 +457,6 @@ static enum ucode_state apply_microcode_late(int cpu)
457457
if (ret != UCODE_UPDATED && ret != UCODE_OK)
458458
return ret;
459459

460-
if (!cpu && uci->cpu_sig.rev != cur_rev) {
461-
pr_info("Updated to revision 0x%x, date = %04x-%02x-%02x\n",
462-
uci->cpu_sig.rev, mc->hdr.date & 0xffff, mc->hdr.date >> 24,
463-
(mc->hdr.date >> 16) & 0xff);
464-
}
465-
466460
cpu_data(cpu).microcode = uci->cpu_sig.rev;
467461
if (!cpu)
468462
boot_cpu_data.microcode = uci->cpu_sig.rev;

0 commit comments

Comments
 (0)