net/mlx5e: Initialize link speed to zero

royno-nvidia · Saeed Mahameed · commit 6e9d51b1a5cb · 2023-03-21T14:06:31.000-07:00
mlx5e_port_max_linkspeed does not guarantee value assignment for speed. Avoid cases where link_speed might be used uninitialized. In case mlx5e_port_max_linkspeed fails, a default link speed of 50000 will be used for the calculations. Fixes: 3f6d08d ("net/mlx5e: Add RSS support for hairpin") Signed-off-by: Roy Novich <royno@nvidia.com> Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Reviewed-by: Aya Levin <ayal@nvidia.com> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -1103,8 +1103,8 @@ static void
 mlx5e_hairpin_params_init(struct mlx5e_hairpin_params *hairpin_params,
 			  struct mlx5_core_dev *mdev)
 {
+	u32 link_speed = 0;
 	u64 link_speed64;
-	u32 link_speed;
 
 	hairpin_params->mdev = mdev;
 	/* set hairpin pair per each 50Gbs share of the link */

Original file line number	Diff line number	Diff line change
`@@ -1103,8 +1103,8 @@ static void`
`1103`	`1103`	`mlx5e_hairpin_params_init(struct mlx5e_hairpin_params *hairpin_params,`
`1104`	`1104`	`struct mlx5_core_dev *mdev)`
`1105`	`1105`	`{`
	`1106`	`+ u32 link_speed = 0;`
`1106`	`1107`	`u64 link_speed64;`
`1107`		`- u32 link_speed;`
`1108`	`1108`
`1109`	`1109`	`hairpin_params->mdev = mdev;`
`1110`	`1110`	`/* set hairpin pair per each 50Gbs share of the link */`