Skip to content

Commit 6ef935e

Browse files
IronShenPaolo Abeni
authored andcommitted
net: hns3: add VLAN id validation before using
Currently, the VLAN id may be used without validation when receive a VLAN configuration mailbox from VF. The length of vlan_del_fail_bmap is BITS_TO_LONGS(VLAN_N_VID). It may cause out-of-bounds memory access once the VLAN id is bigger than or equal to VLAN_N_VID. Therefore, VLAN id needs to be checked to ensure it is within the range of VLAN_N_VID. Fixes: fe4144d ("net: hns3: sync VLAN filter entries when kill VLAN ID failed") Signed-off-by: Jian Shen <shenjian15@huawei.com> Signed-off-by: Jijie Shao <shaojijie@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20251211023737.2327018-4-shaojijie@huawei.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent d180c11 commit 6ef935e

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10555,6 +10555,9 @@ int hclge_set_vlan_filter(struct hnae3_handle *handle, __be16 proto,
1055510555
bool writen_to_tbl = false;
1055610556
int ret = 0;
1055710557

10558+
if (vlan_id >= VLAN_N_VID)
10559+
return -EINVAL;
10560+
1055810561
/* When device is resetting or reset failed, firmware is unable to
1055910562
* handle mailbox. Just record the vlan id, and remove it after
1056010563
* reset finished.

0 commit comments

Comments
 (0)