Skip to content

Commit 6f515b6

Browse files
a-waimmind
authored andcommitted
arm64: dts: rockchip: fix input enable pinconf on rk3399
When the input enable pinconf was introduced, a default drive-strength value of 2 was set for the pull up/down configs. However, this parameter is unneeded when configuring the pin as input, and having a single hardcoded value here is actually harmful: GPIOs on the RK3399 have various same drive-strength capabilities depending on the bank and port they belong to. As an example, trying to configure the GPIO4_PD3 pin as an input with pull-up enabled fails with the following output: [ 10.706542] rockchip-pinctrl pinctrl: unsupported driver strength 2 [ 10.713661] rockchip-pinctrl pinctrl: pin_config_set op failed for pin 155 (acceptable drive-strength values for this pin being 3, 6, 9 and 12) Let's drop the drive-strength property from all input pinconfs in order to solve this issue. Fixes: ec48c3e ("arm64: dts: rockchip: add an input enable pinconf to rk3399") Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com> Reviewed-by: Caleb Connolly <kc@postmarketos.org> Link: https://lore.kernel.org/r/20221215101947.254896-1-arnaud.ferraris@collabora.com Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent 8042233 commit 6f515b6

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3399.dtsi

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2241,13 +2241,11 @@
22412241
pcfg_input_pull_up: pcfg-input-pull-up {
22422242
input-enable;
22432243
bias-pull-up;
2244-
drive-strength = <2>;
22452244
};
22462245

22472246
pcfg_input_pull_down: pcfg-input-pull-down {
22482247
input-enable;
22492248
bias-pull-down;
2250-
drive-strength = <2>;
22512249
};
22522250

22532251
clock {

0 commit comments

Comments
 (0)