Skip to content

Commit 6fe240b

Browse files
Chaitanya KulkarniChristoph Hellwig
authored andcommitted
nvmet-tcp: validate idle poll modparam value
The module parameter idle_poll_period_usecs is passed to the function usecs_to_jiffies() which has following prototype and expect idle_poll_period_usecs arg type to be unsigned int:- unsigned long usecs_to_jiffies(const unsigned int u); Use similar module parameter validation callback as previous patch. Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent 44aef3b commit 6fe240b

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/nvme/target/tcp.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,10 @@ MODULE_PARM_DESC(so_priority, "nvmet tcp socket optimize priority: Default 0");
6161
* using advanced interrupt moderation techniques.
6262
*/
6363
static int idle_poll_period_usecs;
64-
module_param(idle_poll_period_usecs, int, 0644);
64+
device_param_cb(idle_poll_period_usecs, &set_param_ops,
65+
&idle_poll_period_usecs, 0644);
6566
MODULE_PARM_DESC(idle_poll_period_usecs,
66-
"nvmet tcp io_work poll till idle time period in usecs");
67+
"nvmet tcp io_work poll till idle time period in usecs: Default 0");
6768

6869
#define NVMET_TCP_RECV_BUDGET 8
6970
#define NVMET_TCP_SEND_BUDGET 8

0 commit comments

Comments
 (0)