drivers/xen/xenbus: Simplify return statement in join()

toblux · jgross1 · commit 6fec913ff1c9 · 2025-11-17T07:55:10.000+01:00
Don't unnecessarily negate 'buffer' and simplify the return statement.

Reviewed-by: Jason Andryuk &lt;jason.andryuk@amd.com&gt;
Signed-off-by: Thorsten Blum &lt;thorsten.blum@linux.dev&gt;
Signed-off-by: Juergen Gross &lt;jgross@suse.com&gt;
Message-ID: &lt;20251112171410.3140-2-thorsten.blum@linux.dev&gt;
diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c
@@ -407,7 +407,7 @@ static char *join(const char *dir, const char *name)
 		buffer = kasprintf(GFP_NOIO | __GFP_HIGH, "%s", dir);
 	else
 		buffer = kasprintf(GFP_NOIO | __GFP_HIGH, "%s/%s", dir, name);
-	return (!buffer) ? ERR_PTR(-ENOMEM) : buffer;
+	return buffer ?: ERR_PTR(-ENOMEM);
 }
 
 static char **split(char *strings, unsigned int len, unsigned int *num)

Original file line number	Diff line number	Diff line change
`@@ -407,7 +407,7 @@ static char join(const char dir, const char *name)`
`407`	`407`	`buffer = kasprintf(GFP_NOIO \| __GFP_HIGH, "%s", dir);`
`408`	`408`	`else`
`409`	`409`	`buffer = kasprintf(GFP_NOIO \| __GFP_HIGH, "%s/%s", dir, name);`
`410`		`- return (!buffer) ? ERR_PTR(-ENOMEM) : buffer;`
	`410`	`+ return buffer ?: ERR_PTR(-ENOMEM);`
`411`	`411`	`}`
`412`	`412`
`413`	`413`	`static char *split(char strings, unsigned int len, unsigned int *num)`