Skip to content

Commit 7011555

Browse files
Jaehyoung Choikrzk
authored andcommitted
pinctrl: samsung: Fix pinctrl bank pin count
Commit 1abd18d ("pinctrl: samsung: Register pinctrl before GPIO") changes the order of GPIO and pinctrl registration: now pinctrl is registered before GPIO. That means gpio_chip->ngpio is not set when samsung_pinctrl_register() called, and one cannot rely on that value anymore. Use `pin_bank->nr_pins' instead of `pin_bank->gpio_chip.ngpio' to fix mentioned inconsistency. Fixes: 1abd18d ("pinctrl: samsung: Register pinctrl before GPIO") Signed-off-by: Jaehyoung Choi <jkkkkk.choi@samsung.com> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> Link: https://lore.kernel.org/r/20210730192905.7173-1-semen.protsenko@linaro.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
1 parent e73f0f0 commit 7011555

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/pinctrl/samsung/pinctrl-samsung.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -918,7 +918,7 @@ static int samsung_pinctrl_register(struct platform_device *pdev,
918918
pin_bank->grange.pin_base = drvdata->pin_base
919919
+ pin_bank->pin_base;
920920
pin_bank->grange.base = pin_bank->grange.pin_base;
921-
pin_bank->grange.npins = pin_bank->gpio_chip.ngpio;
921+
pin_bank->grange.npins = pin_bank->nr_pins;
922922
pin_bank->grange.gc = &pin_bank->gpio_chip;
923923
pinctrl_add_gpio_range(drvdata->pctl_dev, &pin_bank->grange);
924924
}

0 commit comments

Comments
 (0)