Skip to content

Commit 70171ed

Browse files
Aashish Sharmajic23
authored andcommitted
iio:proximity:sx9324: Check ret value of device_property_read_u32_array()
0-day reports: drivers/iio/proximity/sx9324.c:868:3: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores] Put an if condition to break out of switch if ret is non-zero. Signed-off-by: Aashish Sharma <shraash@google.com> Fixes: a8ee3b3 ("iio:proximity:sx9324: Add dt_binding support") Reported-by: kernel test robot <lkp@intel.com> [swboyd@chromium.org: Reword commit subject, add fixes tag] Signed-off-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Link: https://lore.kernel.org/r/20220613232224.2466278-1-swboyd@chromium.org Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent bf74514 commit 70171ed

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/iio/proximity/sx9324.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -885,6 +885,9 @@ sx9324_get_default_reg(struct device *dev, int idx,
885885
break;
886886
ret = device_property_read_u32_array(dev, prop, pin_defs,
887887
ARRAY_SIZE(pin_defs));
888+
if (ret)
889+
break;
890+
888891
for (pin = 0; pin < SX9324_NUM_PINS; pin++)
889892
raw |= (pin_defs[pin] << (2 * pin)) &
890893
SX9324_REG_AFE_PH0_PIN_MASK(pin);

0 commit comments

Comments
 (0)